Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2421683004:
Updating manifest for Android N (Closed)
DescriptionUpdating manifest for Android N
This change updates the target API level for the Chromoting Android
Client app. It also adds two manifest flags to the Application block,
resizeableActivity (true) and supportsPictureInPicture (false).
The first flag indicates that all activities supports split-screen mode.
The second flag indicates that no activity supports PIP mode.
BUG=632411
Committed: https://crrev.com/7b82aefa60081e3b8c7bdcca09316ebcceeb53a1
Cr-Commit-Position: refs/heads/master@{#429889}
Patch Set 1 #Patch Set 2 : Simplifying the CL by specifying the attributes at the application level instead of the activity le… #Messages
Total messages: 22 (11 generated)
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
joedow@chromium.org changed reviewers: + lambroslambrou@chromium.org
PTAL!
PTAL!
PTAL!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
So Lamdas are allowed now? :P
The CQ bit was checked by joedow@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks Lambros! Yuwei, Java in Chromium basically follows Android style guidelines (with a few exceptions). I'd assume we can if the toolkits support it but the standard best practices for lamdbas should still be applied even if they aren't called out specifically :)
The CQ bit was unchecked by joedow@chromium.org
Description was changed from ========== Updating manifest for Android N This change updates the target API level for the Chromoting Android Client app. It also adds two manifest flags to each Activity which can be interacted with by the user: resizeableActivity (true) and supportsPictureInPicture (false). The first flag indicates that the activity supports split-screen mode. The second flag indicates that it does not support PIP mode. BUG=632411 ========== to ========== Updating manifest for Android N This change updates the target API level for the Chromoting Android Client app. It also adds two manifest flags to the Application block, resizeableActivity (true) and supportsPictureInPicture (false). The first flag indicates that all activities supports split-screen mode. The second flag indicates that no activity supports PIP mode. BUG=632411 ==========
It turns out we can specify resizeable window support in the application element instead of each individual activity element. This should be cleaner since we don't have an full-screen only activities. I've updated the manifest to use this scheme instead. Feel free to take a look if you are interested. The SDK has been in for ~2 weeks now so I think it is safe to begin checking in N changes so I will get started with that now :)
The CQ bit was checked by joedow@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lambroslambrou@chromium.org Link to the patchset: https://codereview.chromium.org/2421683004/#ps20001 (title: "Simplifying the CL by specifying the attributes at the application level instead of the activity le…")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Updating manifest for Android N This change updates the target API level for the Chromoting Android Client app. It also adds two manifest flags to the Application block, resizeableActivity (true) and supportsPictureInPicture (false). The first flag indicates that all activities supports split-screen mode. The second flag indicates that no activity supports PIP mode. BUG=632411 ========== to ========== Updating manifest for Android N This change updates the target API level for the Chromoting Android Client app. It also adds two manifest flags to the Application block, resizeableActivity (true) and supportsPictureInPicture (false). The first flag indicates that all activities supports split-screen mode. The second flag indicates that no activity supports PIP mode. BUG=632411 Committed: https://crrev.com/7b82aefa60081e3b8c7bdcca09316ebcceeb53a1 Cr-Commit-Position: refs/heads/master@{#429889} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7b82aefa60081e3b8c7bdcca09316ebcceeb53a1 Cr-Commit-Position: refs/heads/master@{#429889} |
