Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2421683002: Add Chrome's executable path when launching the CCT. (Closed)

Created:
4 years, 2 months ago by alito
Modified:
4 years, 2 months ago
Reviewers:
csharp, Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Chrome's executable path when launching the CCT. BUG= Committed: https://crrev.com/48849c8947b9eab911644d910625f0aee9209500 Cr-Commit-Position: refs/heads/master@{#425416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/safe_browsing/srt_global_error_win.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alito
PTAL.
4 years, 2 months ago (2016-10-13 22:31:31 UTC) #2
csharp
lgtm
4 years, 2 months ago (2016-10-14 17:31:23 UTC) #3
alito
Adding jialiul@ for Owner's approval.
4 years, 2 months ago (2016-10-14 17:35:41 UTC) #5
Jialiu Lin
lgtm
4 years, 2 months ago (2016-10-14 18:13:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421683002/1
4 years, 2 months ago (2016-10-14 18:19:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 19:09:29 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:11:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48849c8947b9eab911644d910625f0aee9209500
Cr-Commit-Position: refs/heads/master@{#425416}

Powered by Google App Engine
This is Rietveld 408576698