Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issue 2421633003: media: Use native audio enum types in media mojo interfaces (Closed)

Created:
4 years, 2 months ago by xhwang
Modified:
4 years, 2 months ago
Reviewers:
jrummell, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, alokp+watch_chromium.org, darin (slow to review), Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Use native audio enum types in media mojo interfaces BUG=611224 TEST=mojo_media_unittests still pass Committed: https://crrev.com/057055f3bd77eb8de1b4c9cfd488d8854f91fb67 Cr-Commit-Position: refs/heads/master@{#425258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -155 lines) Patch
M media/base/ipc/media_param_traits_macros.h View 2 chunks +8 lines, -1 line 0 comments Download
M media/mojo/common/media_type_converters.cc View 6 chunks +12 lines, -83 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +7 lines, -71 lines 0 comments Download
M media/mojo/interfaces/media_types.typemap View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
xhwang
Another one, PTAL :)
4 years, 2 months ago (2016-10-14 03:19:51 UTC) #6
dcheng
ipc/mojo lgtm
4 years, 2 months ago (2016-10-14 03:55:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421633003/1
4 years, 2 months ago (2016-10-14 05:28:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 05:34:50 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 05:36:35 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/057055f3bd77eb8de1b4c9cfd488d8854f91fb67
Cr-Commit-Position: refs/heads/master@{#425258}

Powered by Google App Engine
This is Rietveld 408576698