Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2421613003: chromevox: Fix a racy failure in directory creation in jsbundler.py. (Closed)

Created:
4 years, 2 months ago by kinaba
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromevox: Fix a racy failure in directory creation in jsbundler.py. Previous implementation can fail if other concurrent task created the directory between path.exists and makedirs. BUG=655750 TEST=Manually build select_to_speak with ninja -j10 many times. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c3fd7a5f37395debb368939ef8cf3eeba32fc140 Cr-Commit-Position: refs/heads/master@{#425268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kinaba
PTAL
4 years, 2 months ago (2016-10-14 06:35:51 UTC) #5
dmazzoni
lgtm
4 years, 2 months ago (2016-10-14 07:25:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421613003/1
4 years, 2 months ago (2016-10-14 07:27:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 07:33:52 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 07:35:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3fd7a5f37395debb368939ef8cf3eeba32fc140
Cr-Commit-Position: refs/heads/master@{#425268}

Powered by Google App Engine
This is Rietveld 408576698