Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2421613002: Lay out table children in visual order, and set position and size. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lay out table children in visual order, and set position and size. Set caption and section positions before the first layout pass, and set the logical height right after. This will help the fragmentation code break at the right places. By doing it in visual order right away we can also get rid of some code that dealt with sections being moved after layout. BUG=534751 Committed: https://crrev.com/7a651c67dd9441867ff84657bd13e97df69bbe3f Cr-Commit-Position: refs/heads/master@{#425425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -58 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/break-in-caption-before-tbody.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/break-in-caption-before-tbody-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/break-in-first-table-section.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/break-in-first-table-section-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/break-in-second-table-section.html View 1 chunk +41 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fragmentation/break-in-second-table-section-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/break-in-tbody-after-caption.html View 1 chunk +38 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fragmentation/break-in-tbody-after-caption-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/tbody-before-thead.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/tbody-before-thead-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 7 chunks +75 lines, -57 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-13 20:32:52 UTC) #4
eae
LGTM
4 years, 2 months ago (2016-10-14 19:16:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421613002/1
4 years, 2 months ago (2016-10-14 19:17:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 19:24:51 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:27:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a651c67dd9441867ff84657bd13e97df69bbe3f
Cr-Commit-Position: refs/heads/master@{#425425}

Powered by Google App Engine
This is Rietveld 408576698