Reland: Make the CPDFXFA_App non-global

Reland: Make the CPDFXFA_App non-global

This reverts commit a282c7380f3964de41ea93c9980b12c4513d3473.

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623
Committed: https://pdfium.googlesource.com/pdfium/+/8837c91c0db8f9205b7e58db97946e9af7958b39

[dsinclair, 2016-10-13 19:35:23]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-10-13 19:35:24]

PTAL, third times a charm?

[Tom Sepez, 2016-10-13 20:43:14]

https://codereview.chromium.org/2421603002/diff/20001/fpdfsdk/cpdfsdk_formfil...
File fpdfsdk/cpdfsdk_formfillenvironment.cpp (left):

https://codereview.chromium.org/2421603002/diff/20001/fpdfsdk/cpdfsdk_formfil...
fpdfsdk/cpdfsdk_formfillenvironment.cpp:61: #ifdef PDF_ENABLE_XFA
this tells XFA that the FF side went first.

https://codereview.chromium.org/2421603002/diff/20001/fpdfsdk/javascript/cjs_...
File fpdfsdk/javascript/cjs_runtime.cpp (left):

https://codereview.chromium.org/2421603002/diff/20001/fpdfsdk/javascript/cjs_...
fpdfsdk/javascript/cjs_runtime.cpp:85: if
(CPDFXFA_App::GetInstance()->GetJSERuntime()) {
This handles the case of XFA going first.

https://codereview.chromium.org/2421603002/diff/20001/fpdfsdk/javascript/cjs_...
fpdfsdk/javascript/cjs_runtime.cpp:91:
m_pFormFillEnv->GetFormFillInfo()->m_pJsPlatform;
This handles the case of FF going first.

[dsinclair, 2016-10-17 12:52:39]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 12:52:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-17 13:02:03]

ping.

[commit-bot: I haz the power, 2016-10-17 13:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 13:39:22]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-18 12:46:22]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-10-18 16:36:46]

What changed since commit a282c738?

[dsinclair, 2016-10-18 16:57:10]

On 2016/10/18 16:36:46, Lei Zhang wrote:
> What changed since commit a282c738?

Patchset 1 is a282c738, patch set 2 is the fixes.

[Lei Zhang, 2016-10-18 23:25:16]

On 2016/10/18 16:57:10, dsinclair wrote:
> On 2016/10/18 16:36:46, Lei Zhang wrote:
> > What changed since commit a282c738?
> 
> Patchset 1 is a282c738, patch set 2 is the fixes.

Thanks, but I'm going to wimp out and defer to Tom.

[Tom Sepez, 2016-10-20 17:05:59]

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfview.cpp#ne...
fpdfsdk/fpdfview.cpp:289: FXJSE_Initialize();
Isn't this going to bring v8 into existence on every PDF open?  I thought at the
present time, we avoided doing this until XFA/FF was first required.

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_app.cpp (right):

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_app.cpp:33: m_pRuntime =
pdfium::MakeUnique<CJS_Runtime>(pFormFillEnv);
Is this a separate runtime than the one that will be used by FF?

[dsinclair, 2016-10-31 15:07:12]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 15:07:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-31 15:07:57]

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfview.cpp#ne...
fpdfsdk/fpdfview.cpp:289: FXJSE_Initialize();
On 2016/10/20 17:05:59, Tom Sepez wrote:
> Isn't this going to bring v8 into existence on every PDF open?  I thought at
the
> present time, we avoided doing this until XFA/FF was first required.

Currently, the call to Initialize() will do FXJSE_Initialize() so this should be
the same, just without the intermediate method call.

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfxfa/cpdfxfa...
File fpdfsdk/fpdfxfa/cpdfxfa_app.cpp (right):

https://codereview.chromium.org/2421603002/diff/40001/fpdfsdk/fpdfxfa/cpdfxfa...
fpdfsdk/fpdfxfa/cpdfxfa_app.cpp:33: m_pRuntime =
pdfium::MakeUnique<CJS_Runtime>(pFormFillEnv);
On 2016/10/20 17:05:59, Tom Sepez wrote:
> Is this a separate runtime than the one that will be used by FF?

It was. Removed now and we use the FF environment instead. Had to do some
cleanup work as there were bits of this that got used during shutdown which
happened after FF was removed.

[commit-bot: I haz the power, 2016-10-31 15:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:34:08]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-01 15:43:43]

ping.

[Tom Sepez, 2016-11-01 17:56:13]

I think this works. LGTM.

[dsinclair, 2016-11-01 18:09:30]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 18:22:39]

Description was changed from

==========
Reland: Make the CPDFXFA_App non-global

This reverts commit a282c7380f3964de41ea93c9980b12c4513d3473.

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623
==========

to

==========
Reland: Make the CPDFXFA_App non-global

This reverts commit a282c7380f3964de41ea93c9980b12c4513d3473.

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623

Committed:
https://pdfium.googlesource.com/pdfium/+/8837c91c0db8f9205b7e58db97946e9af795...
==========

[commit-bot: I haz the power, 2016-11-01 18:22:40]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/8837c91c0db8f9205b7e58db97946e9af795...