NSS: fix session cache lock initialisation.

net/third_party/nss/ssl/ssl3con.c

 /* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
  * SSL3 Protocol
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* TODO(ekr): Implement HelloVerifyRequest on server side. OK for now. */
 
@@ skipping 5575 matching lines @@
             PK11SymKey **   pSymWrapKey;
             pSymWrapKey = &symWrapKeys[i].symWrapKey[j];
             if (*pSymWrapKey) {
                 PK11_FreeSymKey(*pSymWrapKey);
                 *pSymWrapKey = NULL;
             }
         }
     }
 
     PZ_Unlock(symWrapKeysLock);
     ssl_FreeSessionCacheLocks();

[wtc, 2013/09/19 04:37:51]

I think we should remove this ssl_FreeSessionCacheLocks call
and mark ssl_FreeSessionCacheLocks as static.

[agl, 2013/09/19 17:40:51]

Done.

     return SECSuccess;
 }
 
 SECStatus ssl_InitSymWrapKeysLock(void)
 {
     symWrapKeysLock = PZ_NewLock(nssILockOther);
     return symWrapKeysLock ? SECSuccess : SECFailure;
 }
 
 /* Try to get wrapping key for mechanism from in-memory array.
@@ skipping 31 matching lines @@
         return NULL;    /* why are we here?!? */
     }
 
     symWrapMechIndex = ssl_FindIndexByWrapMechanism(masterWrapMech);
     PORT_Assert(symWrapMechIndex >= 0);
     if (symWrapMechIndex < 0)
         return NULL;    /* invalid masterWrapMech. */
 
     pSymWrapKey = &symWrapKeys[symWrapMechIndex].symWrapKey[exchKeyType];
 
-    ssl_InitSessionCacheLocks(PR_TRUE);
+    ssl_InitSessionCacheLocks();
 
     PZ_Lock(symWrapKeysLock);
 
     unwrappedWrappingKey = *pSymWrapKey;
     if (unwrappedWrappingKey != NULL) {
         if (PK11_VerifyKeyOK(unwrappedWrappingKey)) {
             unwrappedWrappingKey = PK11_ReferenceSymKey(unwrappedWrappingKey);
             goto done;
         }
         /* slot series has changed, so this key is no good any more. */
@@ skipping 6797 matching lines @@
             PORT_Free(ss->ssl3.hs.recvdFragments.buf);
         }
     }
 
     ss->ssl3.initialized = PR_FALSE;
 
     SECITEM_FreeItem(&ss->ssl3.nextProto, PR_FALSE);
 }
 
 /* End of ssl3con.c */