Caches the scrollbar's thickness for the given theme and control size

Caches the scrollbar thickness for the given control size
to revert the regression.

BUG=654025
COMPONENT=Scrollbar, Webkit

Committed: https://crrev.com/a044d31c7809559896994c2903d45860e075591e
Cr-Commit-Position: refs/heads/master@{#428868}

[malaykeshav, 2016-10-13 18:33:59]

CL for src perf tryjob to run blink_perf.layout benchmark on all-mac platform(s)

[malaykeshav, 2016-10-14 01:19:15]

Description was changed from

==========
Cache Test

BUG=
==========

to

==========
Caches the scrollbar thickness for the given control size 
to revert the regression.

BUG=654025
COMPONENT=Scrollbar, Webkit
==========

[malaykeshav, 2016-10-14 01:19:19]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 01:19:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-10-14 01:19:43]

The CQ bit was unchecked by malaykeshav@chromium.org

[malaykeshav, 2016-10-14 01:21:39]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 01:22:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-10-14 01:22:19]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[malaykeshav, 2016-10-14 01:22:43]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-10-14 01:22:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 04:47:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 04:47:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[malaykeshav, 2016-10-14 21:43:29]

malaykeshav@chromium.org changed reviewers:
+ oshima@chromium.org

[malaykeshav, 2016-10-14 21:43:30]

PTAL

[oshima, 2016-10-14 23:17:30]

https://codereview.chromium.org/2421573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/Scrollbar.cpp (right):

https://codereview.chromium.org/2421573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/Scrollbar.cpp:72:
m_themeScrollbarThickness = thickness;
don't you have to cache for each controlSize?

[malaykeshav, 2016-10-14 23:18:54]

https://codereview.chromium.org/2421573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/Scrollbar.cpp (right):

https://codereview.chromium.org/2421573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/Scrollbar.cpp:72:
m_themeScrollbarThickness = thickness;
On 2016/10/14 at 23:17:30, oshima wrote:
> don't you have to cache for each controlSize?

For a given scrollbar instance the ControlSize does not change. It is
initialized in the constructor.

[oshima, 2016-10-15 01:34:42]

On 2016/10/14 23:18:54, malaykeshav wrote:
>
https://codereview.chromium.org/2421573002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/scroll/Scrollbar.cpp (right):
> 
>
https://codereview.chromium.org/2421573002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/scroll/Scrollbar.cpp:72:
> m_themeScrollbarThickness = thickness;
> On 2016/10/14 at 23:17:30, oshima wrote:
> > don't you have to cache for each controlSize?
> 
> For a given scrollbar instance the ControlSize does not change. It is
> initialized in the constructor.

Ack.

lgtm

[malaykeshav, 2016-10-16 09:24:44]

malaykeshav@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-10-18 15:25:50]

lgtm

[Xianzhu, 2016-10-18 15:26:17]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-10-18 15:26:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 15:35:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 15:35:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[malaykeshav, 2016-10-18 17:24:23]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:24:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:30:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[malaykeshav, 2016-10-18 17:45:38]

malaykeshav@chromium.org changed reviewers:
+ pdr@chromium.org

[malaykeshav, 2016-10-18 17:45:38]

PTAL

[malaykeshav, 2016-10-21 17:57:33]

On 2016/10/18 at 17:45:38, malaykeshav wrote:
> PTAL

Ping

[pdr., 2016-10-28 21:58:32]

On 2016/10/21 at 17:57:33, malaykeshav wrote:
> On 2016/10/18 at 17:45:38, malaykeshav wrote:
> > PTAL
> 
> Ping

Somehow this slipped my radar. LGTM

[malaykeshav, 2016-10-31 22:07:07]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:07:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:49:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 23:51:12]

Description was changed from

==========
Caches the scrollbar thickness for the given control size 
to revert the regression.

BUG=654025
COMPONENT=Scrollbar, Webkit
==========

to

==========
Caches the scrollbar thickness for the given control size
to revert the regression.

BUG=654025
COMPONENT=Scrollbar, Webkit

Committed: https://crrev.com/a044d31c7809559896994c2903d45860e075591e
Cr-Commit-Position: refs/heads/master@{#428868}
==========

[commit-bot: I haz the power, 2016-10-31 23:51:13]

Patchset 2 (id:??) landed as
https://crrev.com/a044d31c7809559896994c2903d45860e075591e
Cr-Commit-Position: refs/heads/master@{#428868}