Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2421523003: Fix a bug in the shadow walker. (Closed)

Created:
4 years, 2 months ago by Sébastien Marchand
Modified:
4 years, 2 months ago
Reviewers:
chrisha
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix a bug in the shadow walker. #

Patch Set 3 : Fix a bug in the shadow walker. #

Patch Set 4 : Comment. #

Patch Set 5 : Bug fix. #

Patch Set 6 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5 lines) Patch
M syzygy/agent/asan/shadow.cc View 1 2 7 chunks +20 lines, -5 lines 0 comments Download
M syzygy/agent/asan/shadow_unittest.cc View 1 2 3 4 5 2 chunks +68 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2363733003 Patch 240001

Messages

Total messages: 8 (3 generated)
Sébastien Marchand
PTAL.
4 years, 2 months ago (2016-10-14 15:19:16 UTC) #2
chrisha
Shouldn't this have a test or two, to make sure the VirtualQuery logic works?
4 years, 2 months ago (2016-10-14 18:17:44 UTC) #3
chrisha
don't mind me, I'm clearly blind. lgtm!
4 years, 2 months ago (2016-10-14 19:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421523003/100001
4 years, 2 months ago (2016-10-14 19:04:06 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:49:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://github.com/google/syzygy/commit/4aac3f46211fd7359e62c432702359412828e797

Powered by Google App Engine
This is Rietveld 408576698