Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 242150: Implement browserAction.setIcon(ImageData) for extensions. (Closed)

Created:
11 years, 2 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implement browserAction.setIcon(ImageData) for extensions. BUG=23269 TEST=load the test_browser_action sample extension, and click the browser action. Watch it dynamically update. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28136

Patch Set 1 #

Patch Set 2 : compile fixes #

Patch Set 3 : proper diff #

Total comments: 2

Patch Set 4 : common function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -29 lines) Patch
M chrome/browser/extensions/extension_browser_actions_api.cc View 1 3 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 chunk +15 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_action.h View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 2 3 5 chunks +67 lines, -20 lines 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/samples/test_browser_action/background.html View 1 1 chunk +25 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
This is based on http://codereview.chromium.org/251093 .
11 years, 2 months ago (2009-10-05 22:20:03 UTC) #1
Matt Perry
11 years, 2 months ago (2009-10-05 22:20:18 UTC) #2
Aaron Boodman
http://codereview.chromium.org/242150/diff/6001/7005 File chrome/renderer/extensions/extension_process_bindings.cc (right): http://codereview.chromium.org/242150/diff/6001/7005#newcode445 Line 445: request_id, has_callback); Is it possible to factor out ...
11 years, 2 months ago (2009-10-06 00:28:41 UTC) #3
Matt Perry
http://codereview.chromium.org/242150/diff/6001/7005 File chrome/renderer/extensions/extension_process_bindings.cc (right): http://codereview.chromium.org/242150/diff/6001/7005#newcode445 Line 445: request_id, has_callback); On 2009/10/06 00:28:41, Aaron Boodman wrote: ...
11 years, 2 months ago (2009-10-06 00:54:53 UTC) #4
Aaron Boodman
11 years, 2 months ago (2009-10-06 05:55:31 UTC) #5
lgtm!

Powered by Google App Engine
This is Rietveld 408576698