Make sure we always temp-zone parse if we preparse toplevel

Make sure we always temp-zone parse if we preparse toplevel

BUG=

Committed: https://crrev.com/1ac958d4b22de1b5466e3b3f94af4b3b95c79e69
Cr-Commit-Position: refs/heads/master@{#40296}

[Toon Verwaest, 2016-10-13 14:17:27]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-10-13 14:17:28]

ptal. Given that we'll preparse anyway, there's no disadvantage to using the
temp zone.

[Toon Verwaest, 2016-10-13 14:21:30]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 14:21:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 15:05:02]

Dry run: This issue passed the CQ dry run.

[marja, 2016-10-14 07:33:43]

Hmm, I thought you already added the "preparser uses tempzone" logic somewhere?

[Toon Verwaest, 2016-10-14 07:45:14]

It used to expkicitly disallow temp zone for top-level. Now it still disallows
temp zone for non-declaration etc toplevel since tempzones themselves are turned
off in that case (since we'd miss compile hints etc). If we already turned on
lazy toplevel, though, there's no downside to also tempzone parse. I noticed
this is an issue since in code load none of the lazy toplevel functions en d up
in the tempzone for some reason...

[marja, 2016-10-14 08:06:23]

offline discussion:

I had thought https://codereview.chromium.org/2374963002/ already puts all
preparsed functions into temp zones, but apparently that's not the case.

https://codereview.chromium.org/2421493002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2421493002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2646: : (is_lazy_top_level_function ||
Shouldn't this be

use_temp_zone = is_lazy_top_level_function || (FLAG ? can_preparse : ...);

[Toon Verwaest, 2016-10-14 08:09:26]

CanPreparse merges the tempzone condition with conditions for lazy toplevel, so
in that branch is already included and doesn't need explicit whitelisting. This
is just extending the old path...

[marja, 2016-10-14 08:13:29]

lgtm

[Toon Verwaest, 2016-10-14 08:16:39]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-10-14 08:16:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 08:20:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-14 08:21:20]

Description was changed from

==========
Make sure we always temp-zone parse if we preparse toplevel

BUG=
==========

to

==========
Make sure we always temp-zone parse if we preparse toplevel

BUG=

Committed: https://crrev.com/1ac958d4b22de1b5466e3b3f94af4b3b95c79e69
Cr-Commit-Position: refs/heads/master@{#40296}
==========

[commit-bot: I haz the power, 2016-10-14 08:21:21]

Patchset 1 (id:??) landed as
https://crrev.com/1ac958d4b22de1b5466e3b3f94af4b3b95c79e69
Cr-Commit-Position: refs/heads/master@{#40296}