Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp

Issue 2421473004: CSP: Fire 'SecurityPolicyViolation' on the offending element. (Closed)
Patch Set: Test. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
index c9dd09510cad457de3a815e15e8a6cca340ea468..18b2686ad57b7cc3279a9916f4f45d782d5031c1 100644
--- a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
+++ b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
@@ -7,6 +7,7 @@
#include "core/dom/Document.h"
#include "core/fetch/IntegrityMetadata.h"
#include "core/frame/csp/CSPDirectiveList.h"
+#include "core/html/HTMLScriptElement.h"
#include "core/loader/DocumentLoader.h"
#include "core/testing/DummyPageHolder.h"
#include "platform/Crypto.h"
@@ -705,6 +706,7 @@ TEST_F(ContentSecurityPolicyTest, NonceInline) {
<< "`, Nonce: `" << test.nonce << "`");
unsigned expectedReports = test.allowed ? 0u : 1u;
+ HTMLScriptElement* element = HTMLScriptElement::create(*document, true);
// Enforce 'script-src'
Persistent<ContentSecurityPolicy> policy = ContentSecurityPolicy::create();
@@ -713,8 +715,8 @@ TEST_F(ContentSecurityPolicyTest, NonceInline) {
ContentSecurityPolicyHeaderTypeEnforce,
ContentSecurityPolicyHeaderSourceHTTP);
EXPECT_EQ(test.allowed,
- policy->allowInlineScript(contextURL, String(test.nonce),
- ParserInserted, contextLine, content));
+ policy->allowInlineScript(element, contextURL, String(test.nonce),
+ contextLine, content));
EXPECT_EQ(expectedReports, policy->m_violationReportsSent.size());
// Enforce 'style-src'
@@ -724,7 +726,7 @@ TEST_F(ContentSecurityPolicyTest, NonceInline) {
ContentSecurityPolicyHeaderTypeEnforce,
ContentSecurityPolicyHeaderSourceHTTP);
EXPECT_EQ(test.allowed,
- policy->allowInlineStyle(contextURL, String(test.nonce),
+ policy->allowInlineStyle(element, contextURL, String(test.nonce),
contextLine, content));
EXPECT_EQ(expectedReports, policy->m_violationReportsSent.size());
@@ -735,7 +737,7 @@ TEST_F(ContentSecurityPolicyTest, NonceInline) {
ContentSecurityPolicyHeaderTypeReport,
ContentSecurityPolicyHeaderSourceHTTP);
EXPECT_TRUE(policy->allowInlineScript(
- contextURL, String(test.nonce), ParserInserted, contextLine, content));
+ element, contextURL, String(test.nonce), contextLine, content));
EXPECT_EQ(expectedReports, policy->m_violationReportsSent.size());
// Report 'style-src'
@@ -744,8 +746,8 @@ TEST_F(ContentSecurityPolicyTest, NonceInline) {
policy->didReceiveHeader(String("style-src ") + test.policy,
ContentSecurityPolicyHeaderTypeReport,
ContentSecurityPolicyHeaderSourceHTTP);
- EXPECT_TRUE(policy->allowInlineStyle(contextURL, String(test.nonce),
- contextLine, content));
+ EXPECT_TRUE(policy->allowInlineStyle(
+ element, contextURL, String(test.nonce), contextLine, content));
EXPECT_EQ(expectedReports, policy->m_violationReportsSent.size());
}
}

Powered by Google App Engine
This is Rietveld 408576698