Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2421473003: Revert of leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster (Closed)

Created:
4 years, 2 months ago by mtklein
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster (patchset #1 id:1 of https://codereview.chromium.org/2412633002/ ) Reason for revert: Reverting while we think about skia:5854 so the bot doesn't regress further. Original issue's description: > leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2412633002 > > Committed: https://skia.googlesource.com/skia/+/c64ef3563dc8badac3d64544513b03df826cf8c3 TBR=mtklein@chromium.org,bsalomon@google.com,reed@google.com,lsalzman@mozilla.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5854 Committed: https://skia.googlesource.com/skia/+/8f2996c59c6f1b15afbdb52e6c092809c03263da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M include/core/SkSurface.h View 1 chunk +4 lines, -8 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mtklein
Created Revert of leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster
4 years, 2 months ago (2016-10-13 14:45:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421473003/1
4 years, 2 months ago (2016-10-13 14:46:10 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 14:46:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8f2996c59c6f1b15afbdb52e6c092809c03263da

Powered by Google App Engine
This is Rietveld 408576698