components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2421463002: FetchMore functionality backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2421463002: FetchMore functionality backend (Closed)

Patch Set: Introduced callback, removed strategy. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/content_suggestions_service_unittest.cc ('K') | « components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h ('k') | components/ntp_snippets/remote/ntp_snippets_fetcher.h » ('j') | components/ntp_snippets/remote/ntp_snippets_fetcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index b87f20ed039dd8b6f1ccc0fd813e5b23e660280d..1565252d5b320738dd240d11cb8331ded7a7b68f 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -87,6 +87,12 @@ void PhysicalWebPageSuggestionsProvider::FetchSuggestionImage(

FROM_HERE, base::Bind(callback, gfx::Image()));

}

+void PhysicalWebPageSuggestionsProvider::FetchMore(

+ const Category& category,

+ FetchedMoreCallback callback) {

+ // Ignored.

void PhysicalWebPageSuggestionsProvider::ClearHistory(

base::Time begin,

base::Time end,