FetchMore functionality backend

components/ntp_snippets/content_suggestions_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_PROVIDER_H_
 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_PROVIDER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 13 matching lines @@
 // A provider can provide suggestions for multiple ContentSuggestionCategories,
 // but for every category that it provides, it will be the only provider in the
 // system which provides suggestions for that category.
 // Providers are created by the ContentSuggestionsServiceFactory and owned and
 // shut down by the ContentSuggestionsService.
 class ContentSuggestionsProvider {
  public:
   using ImageFetchedCallback = base::Callback<void(const gfx::Image&)>;
   using DismissedSuggestionsCallback = base::Callback<void(
       std::vector<ContentSuggestion> dismissed_suggestions)>;
+  using FetchedMoreCallback =

[vitaliii, 2016/11/01 23:29:57]

nit: FetchMoreCallback or MultipleContentSuggestionCallback

[fhorschig, 2016/11/02 05:05:27]

Renamed (but shorter) in CL 2466863003.

+      base::Callback<void(std::vector<ContentSuggestion> suggestions)>;
 
   // The observer of a provider is notified when new data is available.
   class Observer {
    public:
     // Called when the available content changed.
     // If a provider provides suggestions for multiple categories, this callback
     // is called once per category. The |suggestions| parameter always contains
     // the full list of currently available suggestions for that category, i.e.,
     // an empty list will remove all suggestions from the given category. Note
     // that to clear them from the UI immediately, the provider needs to change
@@ skipping 49 matching lines @@
       const ContentSuggestion::ID& suggestion_id) = 0;
 
   // Fetches the image for the suggestion with the given ID and returns it
   // through the callback. This fetch may occur locally or from the internet.
   // If that suggestion doesn't exist, doesn't have an image or if the fetch
   // fails, the callback gets a null image. The callback will not be called
   // synchronously.
   virtual void FetchSuggestionImage(const ContentSuggestion::ID& suggestion_id,
                                     const ImageFetchedCallback& callback) = 0;
 
+  // A user-triggered request to fetch more content for the given category.

[vitaliii, 2016/11/01 23:29:57]

"User-triggered" seems to be not relevant here, the comment should tell what the
function does, e.g. "Fetches new content suggestions..."

[fhorschig, 2016/11/02 05:05:27]

Done. (in CL 2466863003)

+  // Provides only suggestions that have not been provided. The given |callback|

[vitaliii, 2016/11/01 23:29:57]

This sentence looks contradicting to the next line. "Provides" is ambiguous to
me in this context.

[fhorschig, 2016/11/02 05:05:27]

Done. (in CL 2466863003)

+  // is called with these suggestion, along with all existing suggestions.

[vitaliii, 2016/11/01 23:29:57]

s/suggestion/suggestionS

[fhorschig, 2016/11/02 05:05:27]

Done. (in CL 2466863003)

+  virtual void FetchMore(const Category& category,
+                         const FetchedMoreCallback& callback) = 0;
+
   // Removes history from the specified time range where the URL matches the
   // |filter|. The data removed depends on the provider. Note that the
   // data outside the time range may be deleted, for example suggestions, which
   // are based on history from that time range. Providers should immediately
   // clear any data related to history from the specified time range where the
   // URL matches the |filter|.
   virtual void ClearHistory(
       base::Time begin,
       base::Time end,
       const base::Callback<bool(const GURL& url)>& filter) = 0;
@@ skipping 26 matching lines @@
   CategoryFactory* category_factory() const { return category_factory_; }
 
  private:
   Observer* observer_;
   CategoryFactory* category_factory_;
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_PROVIDER_H_