[PaymentRequest] Make shipping name, address, phone and option each on its own line in the summary

Make shipping name, address, phone and option each on its own line in the shipping summary

BUG=637488
Committed: https://crrev.com/a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f
Cr-Commit-Position: refs/heads/master@{#425493}

[gogerald1, 2016-10-13 22:20:44]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-10-13 22:21:33]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 22:21:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-13 22:23:40]

Description was changed from

==========
format


draft

BUG=
==========

to

==========
Make shipping name, address, phone and option each on its own line in the
shipping summary

BUG=637488
==========

[gogerald1, 2016-10-13 22:25:56]

gogerald@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gogerald1, 2016-10-13 22:25:56]

Hi, PTAL,

[commit-bot: I haz the power, 2016-10-13 23:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 23:18:44]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[gogerald1, 2016-10-14 14:58:36]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2016-10-14 14:58:42]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-10-14 14:58:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-14 15:00:23]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2016-10-14 15:00:23]

Resend to rouslan@ since dfalcantara@ is going ooo soon.

[commit-bot: I haz the power, 2016-10-14 15:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 15:34:33]

Dry run: This issue passed the CQ dry run.

[gone, 2016-10-14 18:47:47]

https://chromiumcodereview.appspot.com/2421433004/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://chromiumcodereview.appspot.com/2421433004/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:465:
* . TOP EXTRA TEXT                                                 | CHEVRON .
You're already forcing the right summary text to be null, so it should be auto
hidden.  The left summary text would then serve the role of the "top extra text"
you're adding, and remove the need to rearrange where views are supposed to go.

[gogerald1, 2016-10-14 19:39:03]

Patchset #2 (id:60001) has been deleted

[gogerald1, 2016-10-14 19:44:05]

Patchset #2 (id:80001) has been deleted

[gogerald1, 2016-10-14 19:44:10]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 19:44:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-14 19:50:10]

https://codereview.chromium.org/2421433004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://codereview.chromium.org/2421433004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:465:
* . TOP EXTRA TEXT                                                 | CHEVRON .
On 2016/10/14 18:47:47, dfalcantara (OOO 10.17-10.23) wrote:
> You're already forcing the right summary text to be null, so it should be auto
> hidden.  The left summary text would then serve the role of the "top extra
text"
> you're adding, and remove the need to rearrange where views are supposed to
go.

Done. Uses one more interface to make it general

[gone, 2016-10-14 19:54:11]

https://codereview.chromium.org/2421433004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://codereview.chromium.org/2421433004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:476:
private TextView mThirdExtraTextView;
If you're generalizing this, you should use a TextView[] to avoid having a
mFourthExtraTextView.  It'd also let you use for loops instead of triplicating
the code.

[commit-bot: I haz the power, 2016-10-14 20:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 20:18:48]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-10-14 21:36:57]

Patchset #3 (id:120001) has been deleted

[gogerald1, 2016-10-14 21:46:32]

https://codereview.chromium.org/2421433004/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
(right):

https://codereview.chromium.org/2421433004/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java:476:
private TextView mThirdExtraTextView;
On 2016/10/14 19:54:11, dfalcantara (OOO 10.17-10.23) wrote:
> If you're generalizing this, you should use a TextView[] to avoid having a
> mFourthExtraTextView.  It'd also let you use for loops instead of triplicating
> the code.

Done. The 'generalizing' I meant just give flexibility to set properties for
each extra text view :-) since we have fixed number of extra text views and
looks will rarely need additional text views.

[gone, 2016-10-14 21:52:12]

lgtm

[gogerald1, 2016-10-14 21:53:54]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-10-14 21:54:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 22:23:36]

Description was changed from

==========
Make shipping name, address, phone and option each on its own line in the
shipping summary

BUG=637488
==========

to

==========
Make shipping name, address, phone and option each on its own line in the
shipping summary

BUG=637488
==========

[commit-bot: I haz the power, 2016-10-14 22:23:38]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-10-14 22:25:45]

Description was changed from

==========
Make shipping name, address, phone and option each on its own line in the
shipping summary

BUG=637488
==========

to

==========
Make shipping name, address, phone and option each on its own line in the
shipping summary

BUG=637488

Committed: https://crrev.com/a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f
Cr-Commit-Position: refs/heads/master@{#425493}
==========

[commit-bot: I haz the power, 2016-10-14 22:25:46]

Patchset 3 (id:??) landed as
https://crrev.com/a76b2e1b6fa1fb27f67d7485bd27f08928e4b65f
Cr-Commit-Position: refs/heads/master@{#425493}