Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: telemetry/telemetry/internal/testing/page_with_swipeables.html

Issue 2421433003: Add ScrollPageToElement to action_runner. (Closed)
Patch Set: scroll element to center instead of top Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/testing/page_with_swipeables.html
diff --git a/telemetry/telemetry/internal/testing/page_with_swipeables.html b/telemetry/telemetry/internal/testing/page_with_swipeables.html
index bd209dcfb2f26969c2f85f8da6ab0cf9217ad11a..8844bb912fdd8d38d6344a27e6d1a9d7f4dd1679 100644
--- a/telemetry/telemetry/internal/testing/page_with_swipeables.html
+++ b/telemetry/telemetry/internal/testing/page_with_swipeables.html
@@ -48,5 +48,6 @@
<div class="tall-and-wide"></div>
+<div id="off-screen"></div>
nednguyen 2016/10/13 23:13:48 How can we be sure that this is off screen?
rnephew (Reviews Here) 2016/10/14 00:13:18 The div above it is 5000x5000 pixels in size, so t
nednguyen 2016/10/14 00:19:02 Ah I see. In your test, can you first assert that
</body>
nednguyen 2016/10/14 00:19:02 can you s.t like another tall-and-wide, then anoth
charliea (OOO until 10-5) 2016/10/14 03:34:29 +1 Without this, we can't really have any confide
</html>

Powered by Google App Engine
This is Rietveld 408576698