Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2227)

Unified Diff: net/quic/core/quic_stream_sequencer_test.cc

Issue 2421403002: Eliminate use of StringPiece(nullptr, n) with non zero n. This constructor is unsupported in C++17'… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_stream_sequencer_test.cc
diff --git a/net/quic/core/quic_stream_sequencer_test.cc b/net/quic/core/quic_stream_sequencer_test.cc
index c3b19d32607f71610c48883fb36bd1eccaaadd22..3903093e999fe4e7706f0b4eb36e5c1f7d2a6b72 100644
--- a/net/quic/core/quic_stream_sequencer_test.cc
+++ b/net/quic/core/quic_stream_sequencer_test.cc
@@ -662,6 +662,9 @@ TEST_F(QuicStreamSequencerTest, OutOfOrderTimestamps) {
EXPECT_EQ(0u, sequencer_->NumBytesBuffered());
}
+// TODO(danzh): Figure out the way to implement this test case without the use
+// of unsupported StringPiece constructor.
+#if 0
TEST_F(QuicStreamSequencerTest, OnStreamFrameWithNullSource) {
// Pass in a frame with data pointing to null address, expect to close
// connection with error.
@@ -671,6 +674,7 @@ TEST_F(QuicStreamSequencerTest, OnStreamFrameWithNullSource) {
QUIC_STREAM_SEQUENCER_INVALID_STATE, _));
sequencer_->OnStreamFrame(frame);
}
+#endif
TEST_F(QuicStreamSequencerTest, ReadvError) {
EXPECT_CALL(stream_, OnDataAvailable());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698