Add operator==(const GURL&, const StringPiece&) to gurl.h

Add operator==(const GURL&, const StringPiece&) to gurl.h.

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467
Committed: https://crrev.com/ebeca8e21727b975523416e9abaa2a4024ac36f5
Cr-Commit-Position: refs/heads/master@{#425863}

[Charlie Harrison, 2016-10-17 18:43:26]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 18:44:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-10-17 18:45:37]

Description was changed from

==========
Add operator==(const GURL&, const StringPiece&).

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

BUG=655467
==========

to

==========
Add operator==(const GURL&, const StringPiece&).

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467
==========

[Charlie Harrison, 2016-10-17 18:45:55]

Description was changed from

==========
Add operator==(const GURL&, const StringPiece&).

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467
==========

to

==========
Add operator==(const GURL&, const StringPiece&) to gurl.h.

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467
==========

[Charlie Harrison, 2016-10-17 19:42:47]

csharrison@chromium.org changed reviewers:
+ brettw@chromium.org

[Charlie Harrison, 2016-10-17 19:42:48]

Hi Brett,
PTAL? This change is now the dependent PS for
https://codereview.chromium.org/2409423005 which just changes callsites.

[commit-bot: I haz the power, 2016-10-17 20:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 20:21:39]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-10-17 22:58:59]

lgtm

https://codereview.chromium.org/2421383003/diff/1/url/gurl.h
File url/gurl.h (right):

https://codereview.chromium.org/2421383003/diff/1/url/gurl.h#newcode446
url/gurl.h:446: // Defiant equality operator!
I think this weird comment can be removed now. I think it was referring to
defining these operators even though they were disallowed by the style guide
(which is no longer the case).

[Charlie Harrison, 2016-10-17 23:07:02]

Thanks! I'll go ahead and land this.

[Charlie Harrison, 2016-10-17 23:07:06]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-10-17 23:07:06]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2421383003/#ps20001
(title: "remove comment")

[commit-bot: I haz the power, 2016-10-17 23:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 00:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:42:39]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2016-10-18 00:50:34]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:51:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 02:35:55]

Description was changed from

==========
Add operator==(const GURL&, const StringPiece&) to gurl.h.

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467
==========

to

==========
Add operator==(const GURL&, const StringPiece&) to gurl.h.

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467
==========

[commit-bot: I haz the power, 2016-10-18 02:35:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-18 02:38:38]

Description was changed from

==========
Add operator==(const GURL&, const StringPiece&) to gurl.h.

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467
==========

to

==========
Add operator==(const GURL&, const StringPiece&) to gurl.h.

This patch moves GURL::operator==(const GURL&) to a free-floating function,
and adds a new function to allow comparisons with StringPiece specs.

The new equality operator should be used when the spec of the URL is known
apriori, and parsing a GURL is not necessary for a comparison. This is
specifically designed to replace the case where we compare:
<url> = GURL(kUrlStringConstant).

One such case is replaced by this patch, and the rest will be modified in
a followup.

Note: this patch requires changes to instances of
base::Bind(&GURL::operator==...). They have been edited to use static_cast
to let Bind know that the operator== acts on GURLs.

BUG=655467

Committed: https://crrev.com/ebeca8e21727b975523416e9abaa2a4024ac36f5
Cr-Commit-Position: refs/heads/master@{#425863}
==========

[commit-bot: I haz the power, 2016-10-18 02:38:40]

Patchset 2 (id:??) landed as
https://crrev.com/ebeca8e21727b975523416e9abaa2a4024ac36f5
Cr-Commit-Position: refs/heads/master@{#425863}