Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: scripts/slave/recipe_modules/pgo/api.py

Issue 2421363002: Use the Chromium-side script to run the PGO benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Use the Chromium-side script to run the PGO benchmarks. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/pgo/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/pgo/api.py
diff --git a/scripts/slave/recipe_modules/pgo/api.py b/scripts/slave/recipe_modules/pgo/api.py
index f938ab1401aec28385f767b7702b56e10f5c91aa..8ff8de4b3d7e66a5ad1fee3e733c470e1e3ca34e 100644
--- a/scripts/slave/recipe_modules/pgo/api.py
+++ b/scripts/slave/recipe_modules/pgo/api.py
@@ -65,24 +65,16 @@ class PGOApi(recipe_api.RecipeApi):
"""
Run a suite of telemetry benchmarks to generate some profiling data.
"""
- for benchmark in _BENCHMARKS_TO_RUN:
- try:
- args = [
- '--checkout-dir', self.m.path['checkout'],
- '--browser-type', self.m.chromium.c.build_config_fs.lower(),
- '--target-bits', self.m.chromium.c.TARGET_BITS,
- '--build-dir', self.m.chromium.output_dir,
- '--benchmark', benchmark,
- ]
- self.m.python(
- 'Telemetry benchmark: %s' % benchmark,
- self.resource('run_benchmark.py'),
- args)
- except self.m.step.StepFailure:
- # Turn the failures into warning, we shouldn't stop the build for a
- # benchmark.
- step_result = self.m.step.active_result
- step_result.presentation.status = self.m.step.WARNING
+ args = [
+ '--browser-type', self.m.chromium.c.build_config_fs.lower(),
+ '--target-cpu', self.m.chromium.c.gyp_env.GYP_DEFINES['target_arch'],
+ '--build-dir', self.m.chromium.output_dir,
+ ]
+ self.m.python(
+ 'Profiling benchmarks.',
+ self.m.path['checkout'].join('build', 'win',
+ 'run_pgo_profiling_benchmarks.py'),
+ args)
def _compile_optimized_image(self, bot_config):
"""
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/pgo/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698