Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: components/spellcheck/browser/spelling_service_client.cc

Issue 2421333002: Protobuf for Traffic Annotation and first use by a URLFetcher. (Closed)
Patch Set: Comments addressed. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/spellcheck/browser/spelling_service_client.cc
diff --git a/components/spellcheck/browser/spelling_service_client.cc b/components/spellcheck/browser/spelling_service_client.cc
index 985732a8db5384f6e4faeac38814249eba9268b6..d9791b3cfde5e77efb08643c9aa16c40183d2c64 100644
--- a/components/spellcheck/browser/spelling_service_client.cc
+++ b/components/spellcheck/browser/spelling_service_client.cc
@@ -102,7 +102,43 @@ bool SpellingServiceClient::RequestTextCheck(
country_code.c_str(), api_key.c_str());
GURL url = GURL(kSpellingServiceURL);
- net::URLFetcher* fetcher = CreateURLFetcher(url).release();
+
+ // Create traffic annotation tag.
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("spellcheck_lookup", R"(
+ semantics {
+ sender: "spellcheck"
+ description:
+ "Google Chrome can provide smarter spell-checking by sending "
+ "text you type into the browser to Google's servers, allowing "
+ "you to use the same spell-checking technology used by Google "
+ "products, such as Docs. If the feature is enabled, Chrome will "
+ "send the entire contents of text fields as you type in them to "
+ "Google along with the browser’s default language. Google "
+ "returns a list of suggested spellings, which will be displayed "
+ "in the context menu."
+ trigger: "User types text into a text field or asks to correct a "
+ "misspelled word."
+ data: "Text a user has typed into a text field. No user identifier "
+ "is sent along with the text."
+ destination: GOOGLE_OWNED_SERVICE
+ }
+ policy {
+ cookies_allowed: false
+ setting:
+ "You can enable or disable this feature via 'Use a web service to "
+ "help resolve spelling errors.' in Chrome's settings under "
+ "Advanced. The feature is disabled by default."
+ policy {
+ SpellCheckServiceEnabled {
+ policy_options {mode: MANDATORY}
+ value: false
+ }
+ }
+ })");
+
+ net::URLFetcher* fetcher =
+ CreateURLFetcher(url, traffic_annotation).release();
data_use_measurement::DataUseUserData::AttachToFetcher(
fetcher, data_use_measurement::DataUseUserData::SPELL_CHECKER);
fetcher->SetRequestContext(
@@ -269,6 +305,8 @@ void SpellingServiceClient::OnURLFetchComplete(const net::URLFetcher* source) {
}
std::unique_ptr<net::URLFetcher> SpellingServiceClient::CreateURLFetcher(
- const GURL& url) {
- return net::URLFetcher::Create(url, net::URLFetcher::POST, this);
+ const GURL& url,
+ net::NetworkTrafficAnnotationTag traffic_annotation) {
+ return net::URLFetcher::Create(url, net::URLFetcher::POST, this,
+ traffic_annotation);
}

Powered by Google App Engine
This is Rietveld 408576698