Protobuf for Traffic Annotation and first use by a URLFetcher.

chrome/browser/net/file_downloader.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/file_downloader.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_fetcher.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 using net::URLFetcher;
 
 const int kNumRetries = 1;
 
 FileDownloader::FileDownloader(const GURL& url,
                                const base::FilePath& path,
                                bool overwrite,
                                net::URLRequestContextGetter* request_context,
                                const DownloadFinishedCallback& callback)
     : callback_(callback),
-      fetcher_(URLFetcher::Create(url, URLFetcher::GET, this)),
       local_path_(path),
       weak_ptr_factory_(this) {
+  net::NetworkTrafficAnnotationTag traffic_annotation =

[battre, 2017/02/01 16:25:58]

FileDownloader should take a net::NetworkTrafficAnnotationTag as a parameter
because it can be used as a network abstraction by different components. I
suggest to remove it from this CL.

[Ramin Halavati, 2017/02/02 07:44:24]

Done.

+      net::DefineNetworkTrafficAnnotation("", R"(
+        semantics {
+          sender: ""
+          description: ""
+          trigger: ""
+          data: ""
+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER
+        }
+        policy {
+          cookies_allowed: false/true
+          cookies_store_exceptions: ""
+          setting: ""
+          policy {
+            [POLICY_NAME] {
+                policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+                value: ...
+            }
+          }
+        })");
+  fetcher_.reset(URLFetcher::Create(url,
+                                    URLFetcher::GET,
+                                    this,
+                                    traffic_annotation).release());
+
   fetcher_->SetRequestContext(request_context);
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SAVE_COOKIES);
   fetcher_->SetAutomaticallyRetryOnNetworkChanges(kNumRetries);
   fetcher_->SaveResponseToTemporaryFile(
       BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
 
   if (overwrite) {
     fetcher_->Start();
   } else {
@@ skipping 54 matching lines @@
 }
 
 void FileDownloader::OnFileMoveDone(bool success) {
   if (!success) {
     DLOG(WARNING) << "Could not move file to "
                   << local_path_.LossyDisplayName();
   }
 
   callback_.Run(success ? DOWNLOADED : FAILED);
 }