Protobuf for Traffic Annotation and first use by a URLFetcher.

net/url_request/url_fetcher.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_FETCHER_H_
 #define NET_URL_REQUEST_URL_FETCHER_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/supports_user_data.h"
 #include "net/base/net_export.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_request.h"
 
 class GURL;
 
 namespace base {
 class FilePath;
 class SequencedTaskRunner;
 class TaskRunner;
 class TimeDelta;
 }
@@ skipping 66 matching lines @@
 
   // Used by SetUploadStreamFactory. The callback should assign a fresh upload
   // data stream every time it's called.
   typedef base::Callback<std::unique_ptr<UploadDataStream>()>
       CreateUploadStreamCallback;
 
   virtual ~URLFetcher();
 
   // |url| is the URL to send the request to. It must be valid.
   // |request_type| is the type of request to make.
   // |d| the object that will receive the callback on fetch completion.

[battre, 2016/10/17 14:58:46]

// DEPRECATED: Please use the version with NetworkTrafficAnnotationTag below
instead.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

   static std::unique_ptr<URLFetcher> Create(
       const GURL& url,
       URLFetcher::RequestType request_type,
       URLFetcherDelegate* d);
 
   // Like above, but if there's a URLFetcherFactory registered with the
   // implementation it will be used. |id| may be used during testing to identify
   // who is creating the URLFetcher.

[battre, 2016/10/17 14:58:46]

// DEPRECATED: Please use the version with NetworkTrafficAnnotationTag below
instead.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

   static std::unique_ptr<URLFetcher> Create(
       int id,
       const GURL& url,
       URLFetcher::RequestType request_type,
       URLFetcherDelegate* d);
 
+  // |url| is the URL to send the request to. It must be valid.
+  // |request_type| is the type of request to make.
+  // |d| the object that will receive the callback on fetch completion.

[battre, 2016/10/17 14:58:46]

// |traffic_annotation| metadata about the network traffic send via this
URLFetcher. See net::DefineNetworkTrafficAnnotation.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

+  // This function is a proposed replacement of original Create function to add
+  // traffic annotation as a mandatory parameter.

[battre, 2016/10/17 14:58:46]

Delete this sentence.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

+  static std::unique_ptr<URLFetcher> Create(
+      const GURL& url,
+      URLFetcher::RequestType request_type,
+      URLFetcherDelegate* d,
+      NetworkTrafficAnnotationTag traffic_annotation);
+
+  // Like above, but if there's a URLFetcherFactory registered with the
+  // implementation it will be used. |id| may be used during testing to identify
+  // who is creating the URLFetcher.
+  // This function is a proposed replacement of original Create function to add
+  // traffic annotation as a mandatory parameter.

[battre, 2016/10/17 14:58:46]

Delete this sentence.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

+  static std::unique_ptr<URLFetcher> Create(
+      int id,
+      const GURL& url,
+      URLFetcher::RequestType request_type,
+      URLFetcherDelegate* d,
+      NetworkTrafficAnnotationTag traffic_annotation);
+
   // Cancels all existing URLFetchers.  Will notify the URLFetcherDelegates.
   // Note that any new URLFetchers created while this is running will not be
   // cancelled.  Typically, one would call this in the CleanUp() method of an IO
   // thread, so that no new URLRequests would be able to start on the IO thread
   // anyway.  This doesn't prevent new URLFetchers from trying to post to the IO
   // thread though, even though the task won't ever run.
   static void CancelAll();
 
   // Normally, URLFetcher will abort loads that request SSL client certificate
   // authentication, but this method may be used to cause URLFetchers to ignore
@@ skipping 199 matching lines @@
   // be removed once the URLFetcher is destroyed.  User should not take
   // ownership more than once, or call this method after taking ownership.
   virtual bool GetResponseAsFilePath(
       bool take_ownership,
       base::FilePath* out_response_path) const = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_FETCHER_H_