Protobuf for Traffic Annotation and first use by a URLFetcher.

components/spellcheck/browser/spelling_service_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/spellcheck/browser/spelling_service_client.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 84 matching lines @@
       "\"originCountry\":\"%s\","
       "\"key\":%s"
       "}"
       "}";
   std::string api_key = base::GetQuotedJSONString(google_apis::GetAPIKey());
   std::string request = base::StringPrintf(
       kSpellingRequest, type, encoded_text.c_str(), language_code.c_str(),
       country_code.c_str(), api_key.c_str());
 
   GURL url = GURL(kSpellingServiceURL);
-  net::URLFetcher* fetcher = CreateURLFetcher(url).release();
+
+  // Create traffic annotation tag.
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("spellcheck_lookup", R"(
+        semantics {
+          sender: "spellcheck"
+          description: "Sends the text a user types into a text field in the "
+                       "content area of the browser. Also sends a misspelled "
+                       "word, if a user right-clicks on it."

[battre, 2016/10/17 14:58:45]

Looking at this again, I think that we need to describe what happens but also
what the value proposition is.

description:
Google Chrome can provide smarter spell-checking by sending text you type into
the browser to Google's servers, allowing you to use the same spell-checking
technology used by Google products, such as Docs. If the feature is enabled,
Chrome will send the entire contents of text fields as you type in them to
Google along with the browser’s default language. Google returns a list of
suggested spellings, which will be displayed in the context menu.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

+          trigger: "User types something or asks to correct a misspelled word."

[battre, 2016/10/17 14:58:45]

trigger:
User types text into a text field or asks to correct a misspelled word.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

+          data: "Text a user has typed into a text field. No user identifier "
+                "is sent along with the text."
+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting: "You can disable 'Use a web service to help resolve "
+                   "spelling errors.' in Chrome's settings under Advanced."

[battre, 2016/10/17 14:58:45]

You can enable or disable this feature via '...' .... The feature is disabled by
default.

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

+          policy: "SpellCheckServiceEnabled: "

[battre, 2016/10/17 14:58:45]

nit: no space after colon

[Ramin Halavati, 2016/10/18 06:57:56]

Done.

+                  "  policy_options: MANDATORY"
+                  "  value: false"
+        })");
+
+  net::URLFetcher* fetcher =
+      CreateURLFetcher(url, traffic_annotation).release();
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher, data_use_measurement::DataUseUserData::SPELL_CHECKER);
   fetcher->SetRequestContext(
       content::BrowserContext::GetDefaultStoragePartition(context)
           ->GetURLRequestContext());
   fetcher->SetUploadData("application/json", request);
   fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                         net::LOAD_DO_NOT_SAVE_COOKIES);
   spellcheck_fetchers_[fetcher] = base::MakeUnique<TextCheckCallbackData>(
       base::WrapUnique(fetcher), callback, text);
@@ skipping 146 matching lines @@
     source->GetResponseAsString(&data);
     success = ParseResponse(data, &results);
   }
 
   // The callback may release the last (transitive) dependency on |this|. It
   // MUST be the last function called.
   callback_data->callback.Run(success, callback_data->text, results);
 }
 
 std::unique_ptr<net::URLFetcher> SpellingServiceClient::CreateURLFetcher(
-    const GURL& url) {
-  return net::URLFetcher::Create(url, net::URLFetcher::POST, this);
+    const GURL& url,
+    net::NetworkTrafficAnnotationTag traffic_annotation) {
+  return net::URLFetcher::Create(url, net::URLFetcher::POST, this,
+                                 traffic_annotation);
 }