Created new account type for ARC++ kiosk.

Created new account type for ARC++ kiosk.
The main goal of this CL is to split the CL of a new type of session, that will launch Android app in full screen mode.
The of account type introduced here has one key property - it must be affiliated. This property is covered by unittest.
More tests (including browser tests) will be written for complete session.

BUG=634497
TEST=unittest

Committed: https://crrev.com/53c440d7e5e8c9dd7b9cff5d8339779688605521
Cr-Commit-Position: refs/heads/master@{#427351}

[peletskyi, 2016-10-17 13:18:54]

The CQ bit was checked by peletskyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 13:19:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peletskyi, 2016-10-17 13:23:04]

peletskyi@chromium.org changed reviewers:
+ jamescook@chromium.org, nkostylev@chromium.org, sdefresne@chromium.org,
stevenjb@chromium.org

[peletskyi, 2016-10-17 13:23:05]

Hi guys,
can you please review this CL?
jamescook@chromium.org: ash
nkostylev@chromium.org: chrome/browser/chromeos
sdefresne@chromium.org: components/user_manager
stevenjb@chromium.org: chromeos/login/login_state.h,
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc

[commit-bot: I haz the power, 2016-10-17 13:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 13:56:37]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-10-17 14:44:16]

sdefresne@chromium.org changed reviewers:
+ xiyuan@chromium.org

[sdefresne, 2016-10-17 14:44:16]

-sdefresne, +xiyuan: for components/user_manager

[Nikita (slow), 2016-10-17 15:15:02]

chromeos/login/login_state.h
chrome/browser/chromeos
components/user_manager

lgtm

[Nikita (slow), 2016-10-17 15:15:04]

chromeos/login/login_state.h
chrome/browser/chromeos
components/user_manager

lgtm

[James Cook, 2016-10-17 15:51:49]

ash looks good in general, but where are the tests?

ARC is difficult to test manually on Linux desktop. Kiosk mode is a relatively
rare use case compared to daily browsing. These sorts of CLs need even more test
coverage than normal ones, as breakage will be discovered late and will be
harder than normal to debug.

Please update CL description to provide a brief description of what you did and
why this change must be made. Also, all CLs must include a TEST= line (even if
that line is TEST=none).

[peletskyi, 2016-10-18 08:44:15]

Description was changed from

==========
Created new account type for ARC++ kiosk.

BUG=634497
==========

to

==========
Created new account type for ARC++ kiosk.
The main goal of this CL is to split the CL of a new type of session, that will
launch Android app in full screen mode.
The of account type introduced here has one key property - it must be
affiliated. This property is covered by unittest.
More tests (including browser tests) will be written for complete session.

BUG=634497
TEST=unittest
==========

[peletskyi, 2016-10-18 08:44:53]

On 2016/10/17 15:51:49, James Cook wrote:
> ash looks good in general, but where are the tests?
> 
> ARC is difficult to test manually on Linux desktop. Kiosk mode is a relatively
> rare use case compared to daily browsing. These sorts of CLs need even more
test
> coverage than normal ones, as breakage will be discovered late and will be
> harder than normal to debug.
> 
> Please update CL description to provide a brief description of what you did
and
> why this change must be made. Also, all CLs must include a TEST= line (even if
> that line is TEST=none).

PTAL

[James Cook, 2016-10-18 15:33:17]

ash and CL description LGTM

https://codereview.chromium.org/2421323002/diff/1/ash/system/chromeos/screen_...
File ash/system/chromeos/screen_layout_observer.cc (right):

https://codereview.chromium.org/2421323002/diff/1/ash/system/chromeos/screen_...
ash/system/chromeos/screen_layout_observer.cc:87: }
nit: add "break" above, or "return false" and remove the return false below.

[stevenjb, 2016-10-18 17:14:38]

lgtm

[peletskyi, 2016-10-24 19:27:27]

On 2016/10/18 17:14:38, stevenjb wrote:
> lgtm

xiyuan, friendly ping

[achuithb, 2016-10-24 19:32:33]

On 2016/10/24 19:27:27, peletskyi wrote:
> On 2016/10/18 17:14:38, stevenjb wrote:
> > lgtm
> 
> xiyuan, friendly ping

He's OOO on jury duty. lgtm for components/user_manager

[peletskyi, 2016-10-24 19:44:44]

The CQ bit was checked by peletskyi@chromium.org

[peletskyi, 2016-10-24 19:44:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, nkostylev@chromium.org
Link to the patchset: https://codereview.chromium.org/2421323002/#ps20001
(title: "Fixed nit")

[peletskyi, 2016-10-24 19:45:18]

On 2016/10/24 19:32:33, achuithb wrote:
> On 2016/10/24 19:27:27, peletskyi wrote:
> > On 2016/10/18 17:14:38, stevenjb wrote:
> > > lgtm
> > 
> > xiyuan, friendly ping
> 
> He's OOO on jury duty. lgtm for components/user_manager

Thanks everyone for the review!

[commit-bot: I haz the power, 2016-10-24 19:45:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:48:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:48:58]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[peletskyi, 2016-10-25 14:16:20]

The CQ bit was checked by peletskyi@chromium.org

[peletskyi, 2016-10-25 14:16:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, nkostylev@chromium.org, stevenjb@chromium.org,
achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2421323002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-25 14:16:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 15:10:20]

Description was changed from

==========
Created new account type for ARC++ kiosk.
The main goal of this CL is to split the CL of a new type of session, that will
launch Android app in full screen mode.
The of account type introduced here has one key property - it must be
affiliated. This property is covered by unittest.
More tests (including browser tests) will be written for complete session.

BUG=634497
TEST=unittest
==========

to

==========
Created new account type for ARC++ kiosk.
The main goal of this CL is to split the CL of a new type of session, that will
launch Android app in full screen mode.
The of account type introduced here has one key property - it must be
affiliated. This property is covered by unittest.
More tests (including browser tests) will be written for complete session.

BUG=634497
TEST=unittest
==========

[commit-bot: I haz the power, 2016-10-25 15:10:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 15:12:21]

Description was changed from

==========
Created new account type for ARC++ kiosk.
The main goal of this CL is to split the CL of a new type of session, that will
launch Android app in full screen mode.
The of account type introduced here has one key property - it must be
affiliated. This property is covered by unittest.
More tests (including browser tests) will be written for complete session.

BUG=634497
TEST=unittest
==========

to

==========
Created new account type for ARC++ kiosk.
The main goal of this CL is to split the CL of a new type of session, that will
launch Android app in full screen mode.
The of account type introduced here has one key property - it must be
affiliated. This property is covered by unittest.
More tests (including browser tests) will be written for complete session.

BUG=634497
TEST=unittest

Committed: https://crrev.com/53c440d7e5e8c9dd7b9cff5d8339779688605521
Cr-Commit-Position: refs/heads/master@{#427351}
==========

[commit-bot: I haz the power, 2016-10-25 15:12:23]

Patchset 3 (id:??) landed as
https://crrev.com/53c440d7e5e8c9dd7b9cff5d8339779688605521
Cr-Commit-Position: refs/heads/master@{#427351}