Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: git_cl.py

Issue 2421253002: Gerrit git cl: make it work with minimal file. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index a61bb9144687a796f002f51cbce6c48299ccbfa5..d8b90046c27dafb7ca4cf4e15d830c9754450290 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -3064,7 +3064,8 @@ def LoadCodereviewSettingsFromFile(fileobj):
else:
RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
- SetProperty('server', 'CODE_REVIEW_SERVER')
+ if not keyvals.get('GERRIT_HOST', False):
+ SetProperty('server', 'CODE_REVIEW_SERVER')
# Only server setting is required. Other settings can be absent.
# In that case, we ignore errors raised during option deletion attempt.
SetProperty('cc', 'CC_LIST', unset_error_ok=True)
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698