Put histogram code in one place for CanvasAsyncBlobCreator

Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().

TBR=junov@chromium.org
BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/d882e57ac375d777e9b3c6105049eca508908a8d
Cr-Commit-Position: refs/heads/master@{#425993}

[xlai (Olivia), 2016-10-17 19:28:27]

Description was changed from

==========
Put histogram code in one place for CanvasAsyncBlobCreator

BUG=None
==========

to

==========
Put histogram code in one place for CanvasAsyncBlobCreator

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-10-17 19:30:50]

Patchset #1 (id:1) has been deleted

[xlai (Olivia), 2016-10-17 19:34:16]

Description was changed from

==========
Put histogram code in one place for CanvasAsyncBlobCreator

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the 
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().


BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-10-17 19:34:16]

xlai@chromium.org changed reviewers:
+ xidachen@chromium.org

[xlai (Olivia), 2016-10-17 19:35:26]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-10-18 15:02:08]

lgtm with nits.

https://codereview.chromium.org/2421203003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
(right):

https://codereview.chromium.org/2421203003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp:95: 
nits: Could you please put a comment here saying that this enum is used in
histogram, so it should be append-only.

[xlai (Olivia), 2016-10-18 15:17:21]

Description was changed from

==========
Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the 
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().


BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the 
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().

TBR=junov@chromium.org
BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-10-18 15:17:26]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-10-18 15:17:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
xidachen@chromium.org
Link to the patchset: https://codereview.chromium.org/2421203003/#ps60001
(title: "Rebase and Nits")

[commit-bot: I haz the power, 2016-10-18 15:17:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 16:59:28]

Description was changed from

==========
Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the 
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().

TBR=junov@chromium.org
BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the 
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().

TBR=junov@chromium.org
BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-18 16:59:29]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-18 17:01:56]

Description was changed from

==========
Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the 
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().

TBR=junov@chromium.org
BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Put histogram code in one place for CanvasAsyncBlobCreator

This CL causes no behavior change. It's to organize the
histogram code scattered around CanvasAsyncBlobCreator in
order to:
(1) Facilitate OffscreenCanvas.convertToBlob() implementation
(2) Makes it easier to future histogram addition for
    OffscreenCanvas.convertToBlob().

TBR=junov@chromium.org
BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/d882e57ac375d777e9b3c6105049eca508908a8d
Cr-Commit-Position: refs/heads/master@{#425993}
==========

[commit-bot: I haz the power, 2016-10-18 17:01:57]

Patchset 3 (id:??) landed as
https://crrev.com/d882e57ac375d777e9b3c6105049eca508908a8d
Cr-Commit-Position: refs/heads/master@{#425993}