Issue 24212005: Get rid of returnTypeOfElement (abstract) and typeOfElementWithSelector (concrete method assuming t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24212005: Get rid of returnTypeOfElement (abstract) and typeOfElementWithSelector (concrete method assuming t… (Closed)

Created:
7 years, 3 months ago by polux

Modified:
6 years, 4 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get rid of returnTypeOfElement (abstract) and typeOfElementWithSelector (concrete method assuming the existence of returnTypeOfElement) in InferrerEngine. Since typeOfElementWithSelector is used in several inferrers (InternalSimpleTypesInferrer and TypeGraphInferrerEngine), move the two methods in a new SimpleInferrerEngine class and use it in lieu of InferrerEngine where necessary. Modify SimpleTypeInferrerVisitor to use the return type of registerCalledElement whenever returnTypeOfElement was used.

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -51 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View		5 chunks	+60 lines, -47 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/types/type_graph_inferrer.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages