Issue 24212004: Avoid useless call to v8::Isolate::GetCurrent() in ScriptPromiseResolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24212004: Avoid useless call to v8::Isolate::GetCurrent() in ScriptPromiseResolver (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken, marja

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Avoid useless call to v8::Isolate::GetCurrent() in ScriptPromiseResolver Avoid useless call to v8::Isolate::GetCurrent() in ScriptPromiseResolver by retrieving the isolate from the ScriptExecutionContext. R=haraken BUG=263412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158118

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Source/bindings/v8/ScriptPromiseResolver.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/24212004/1

7 years, 3 months ago (2013-09-20 13:37:41 UTC) #3

Message was sent while issue was closed.

Change committed as 158118

Expand Messages | Collapse Messages