Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 2421193002: [turbofan] Add missing Float32 -> TaggedSigned conversion. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add missing Float32 -> TaggedSigned conversion. There are a couple of operators that can indeed produce Float32 representation, which we might end up using in a TaggedSigned context, so add the missing conversion (indirectly via Float64). BUG=chromium:656275 R=jarin@chromium.org Committed: https://crrev.com/96f1327a93c4333aaf3d642866922e724113804e Cr-Commit-Position: refs/heads/master@{#40334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M src/compiler/representation-change.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-656275.js View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-17 04:39:12 UTC) #1
Jarin
lgtm
4 years, 2 months ago (2016-10-17 05:37:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421193002/1
4 years, 2 months ago (2016-10-17 05:38:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 05:40:49 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 05:41:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96f1327a93c4333aaf3d642866922e724113804e
Cr-Commit-Position: refs/heads/master@{#40334}

Powered by Google App Engine
This is Rietveld 408576698