Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: chrome/browser/sync/engine/syncapi.h

Issue 242118: Change the Windows build to statically link the sync library. (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome.dll.deps ('k') | chrome/browser/sync/engine/syncapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncapi.h
diff --git a/chrome/browser/sync/engine/syncapi.h b/chrome/browser/sync/engine/syncapi.h
index d8e2601b674cf46001757028daf88fda5c4a62d0..474a7a58e415f2df2c8803bfaca3a9a9150ad5f3 100644
--- a/chrome/browser/sync/engine/syncapi.h
+++ b/chrome/browser/sync/engine/syncapi.h
@@ -48,18 +48,10 @@ typedef uint16 sync_char16;
#endif
// The MSVC compiler for Windows requires that any classes exported by, or
-// imported from, a dynamic library be decorated with the following fanciness.
-#if defined(OS_WIN)
-#if COMPILING_SYNCAPI_LIBRARY
-#define SYNC_EXPORT __declspec(dllexport)
-#elif COMPILING_SYNCAPI_STUB
-#define SYNC_EXPORT
-#else
-#define SYNC_EXPORT __declspec(dllimport)
-#endif
-#else
+// imported from, a dynamic library be marked with an appropriate
tim (not reviewing) 2009/10/05 23:51:27 You be using some unaccurate engrish there matey.
+// __declspec() decoration. However, we currently use static linkage
+// on all platforms.
#define SYNC_EXPORT
-#endif // OS_WIN
// Forward declarations of internal class types so that sync API objects
// may have opaque pointers to these types.
« no previous file with comments | « chrome/app/chrome.dll.deps ('k') | chrome/browser/sync/engine/syncapi.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698