Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 242118: Change the Windows build to statically link the sync library. (Closed)

Created:
11 years, 2 months ago by ncarter (slow)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change the Windows build to statically link the sync library. Update installer files so that they don't reference syncapi.dll. Add a reference to iphlpapi, and make it and pthreads lazy-loaded. BUG=23609 TEST=interactive testing of two sync clients with notifications. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28112

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -64 lines) Patch
M chrome/app/chrome.dll.deps View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 1 chunk +3 lines, -11 lines 1 comment Download
M chrome/browser/sync/engine/syncapi.cc View 5 chunks +4 lines, -23 lines 0 comments Download
M chrome/chrome.gyp View 6 chunks +3 lines, -26 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/tools/build/win/FILES View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ncarter (slow)
I still need to do additional testing (I want to single-step through the initialization code, ...
11 years, 2 months ago (2009-10-02 02:35:40 UTC) #1
ncarter (slow)
More info: This adds 681984 bytes to a release chrome.dll (while eliminating syncapi.dll, which was ...
11 years, 2 months ago (2009-10-02 02:38:27 UTC) #2
ncarter (slow)
Ping.
11 years, 2 months ago (2009-10-05 20:32:12 UTC) #3
tim (not reviewing)
11 years, 2 months ago (2009-10-05 23:51:27 UTC) #4
LGTM

http://codereview.chromium.org/242118/diff/1/4
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/242118/diff/1/4#newcode51
Line 51: // imported from, a dynamic library be marked with an appropriate
You be using some unaccurate engrish there matey.

Powered by Google App Engine
This is Rietveld 408576698