Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2421133002: Disable row stretching for tables crossing fragmentainer boundaries. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable row stretching for tables crossing fragmentainer boundaries. Edge also does this. Allowing rows to be stretched and thus moved after fragmentation would require us to re-fragment (since the fragmentainer boundaries would be elsewhere, due to row stretching), then re-stretch, the re-re-fragment, and so on (cyclic dependencies). BUG=534751 Committed: https://crrev.com/1f890b5c1a8df2d427087f57bc50cd4b2e86b9eb Cr-Commit-Position: refs/heads/master@{#425705}

Patch Set 1 #

Patch Set 2 : Use fixed line-height in test, so that it passes everywhere, not just Linux. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/fragmented-table-with-fixed-height.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/fragmented-table-with-fixed-height-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-17 09:00:08 UTC) #11
eae
LGTM
4 years, 2 months ago (2016-10-17 16:53:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421133002/20001
4 years, 2 months ago (2016-10-17 17:04:04 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 17:08:48 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 17:12:06 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f890b5c1a8df2d427087f57bc50cd4b2e86b9eb
Cr-Commit-Position: refs/heads/master@{#425705}

Powered by Google App Engine
This is Rietveld 408576698