Issue 242113014: Partial revert of r164563 as those changes have no effect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242113014: Partial revert of r164563 as those changes have no effect (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
tkent, eseidel

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan, gnanasekar

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Partial revert of r164563 as those changes have no effect Revert the changes to HTMLSelectElement.cpp from r164563 as those changes have no effect and the layout test added in that commit still passes without. The dragSelection variable is set to true in an "else if" scope. Therefore, it can never be true when it is evaluated in another "else if" scope below. The clang static code analyzer was complaining about the dragSelection=true being a dead assignment. R=tkent@chromium.org, eseidel@chromium.org BUG=317809 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172005

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	Source/core/html/HTMLSelectElement.cpp	View		2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/242113014/1

6 years, 8 months ago (2014-04-20 23:51:02 UTC) #3

Message was sent while issue was closed.

Change committed as 172005

Expand Messages | Collapse Messages