Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: Source/core/html/track/TextTrack.cpp

Issue 242113012: Make text track and cue wrapper objects dependent on their media element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Consistently use a Node-returning owner() Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 const AtomicString& TextTrack::interfaceName() const 421 const AtomicString& TextTrack::interfaceName() const
422 { 422 {
423 return EventTargetNames::TextTrack; 423 return EventTargetNames::TextTrack;
424 } 424 }
425 425
426 ExecutionContext* TextTrack::executionContext() const 426 ExecutionContext* TextTrack::executionContext() const
427 { 427 {
428 return m_document; 428 return m_document;
429 } 429 }
430 430
431 HTMLMediaElement* TextTrack::mediaElement() 431 HTMLMediaElement* TextTrack::mediaElement() const
432 { 432 {
433 return m_trackList ? m_trackList->owner() : 0; 433 return m_trackList ? m_trackList->owner() : 0;
434 } 434 }
435
436 Node* TextTrack::owner() const
437 {
438 return m_trackList ? m_trackList->owner() : 0;
acolwell GONE FROM CHROMIUM 2014/04/21 16:51:16 nit: Any reason not to just forward to mediaElemen
sof 2014/04/21 18:35:01 None at all, done. Ideally [SetWrapperReferenceFro
439 }
435 440
436 } // namespace WebCore 441 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698