LayoutTests/media/track/text-track-cue-is-reachable-expected.txt - Issue 242113012: Make text track and cue wrapper objects dependent on their media element.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/text-track-cue-is-reachable-expected.txt

Issue 242113012: Make text track and cue wrapper objects dependent on their media element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Consistently use a Node-returning owner() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Ensure that a TextTrackCue won't be collected if it has a custom property.	1 Ensure that a TextTrackCue won't be collected if it has a custom property.

2	2

3 ** Validate.	3 ** Validate.

4 EXPECTED (video.textTracks[0].cues.length == '4') OK	4 EXPECTED (video.textTracks[0].cues.length == '4') OK

5 EXPECTED (video.textTracks[0].cues[1].startTime == '31') OK	5 EXPECTED (video.textTracks[0].cues[1].startTime == '31') OK

6	6

7 ** Add a custom property to a cue.	7 ** Add a custom property to a cue.

8 RUN(video.textTracks[0].cues[1].myProperty = 'tuna salad?')	8 RUN(video.textTracks[0].cues[1].myProperty = 'tuna salad?')

9 EXPECTED (video.textTracks[0].cues[1].myProperty == 'tuna salad?') OK	9 EXPECTED (video.textTracks[0].cues[1].myProperty == 'tuna salad?') OK

10	10

11 ** Force garbage collection.	11 ** Force garbage collection.

12 EXPECTED (video.textTracks[0].cues.length == '4') OK	12 EXPECTED (video.textTracks[0].cues.length == '4') OK

13 EXPECTED (video.textTracks[0].cues[1].myProperty == 'tuna salad?'), OBSERVED 'un defined' FAIL	13 EXPECTED (video.textTracks[0].cues[1].myProperty == 'tuna salad?') OK

14	14

15 END OF TEST	15 END OF TEST

16	16

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/track/text-track-is-reachable-expected.txt » ('j') | LayoutTests/media/track/track-cue-gc-wrapper.html » ('J')