Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 242113005: Introduce DropUnderReturnAddress for x64 port. (Closed)

Created:
6 years, 8 months ago by haitao.feng
Modified:
6 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Introduce DropUnderReturnAddress for x64 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M src/x64/builtins-x64.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
haitao.feng
Hi Toon, this is the CL we discussed two weeks ago. After this change, there ...
6 years, 8 months ago (2014-04-18 02:44:19 UTC) #1
haitao.feng
The CQ bit was checked by haitao.feng@intel.com
6 years, 8 months ago (2014-04-21 01:47:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/haitao.feng@intel.com/242113005/1
6 years, 8 months ago (2014-04-21 01:47:51 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 01:47:52 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-21 01:47:52 UTC) #5
Toon Verwaest
lgtm
6 years, 7 months ago (2014-04-29 09:51:38 UTC) #6
haitao.feng
6 years, 7 months ago (2014-04-30 09:23:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r21082 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698