Remove 'use_mirror' and 'root' properties.

Remove 'use_mirror' and 'root' properties.

Remove the recipe engine special case "use_mirror" and "root" property
logic. "root" is very old, and "use_mirror" is no longer useful now that
SVN is deprecated in Chromium. Additionally, the "use_mirror" logic
should have been determined in the "gclient" recipe module, not in the
core recipe engine.

BUG=chromium:656731
TEST=None

Committed: https://github.com/luci/recipes-py/commit/bb6caf8060139fd4bcefee43f54ae00150e7ce3a

[dnj, 2016-10-15 15:14:31]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, martiniss@chromium.org

[dnj, 2016-10-15 15:14:32]

PTAL

[tandrii(chromium), 2016-10-17 17:41:46]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-10-17 17:41:46]

lgtm % if it doesn't break code like this
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/perf_dash...

[dnj, 2016-10-17 18:41:45]

Description was changed from

==========
Remove 'use_mirror' and 'root' properties.

Remove the recipe engine special case "use_mirror" and "root" property
logic. "root" is very old, and "use_mirror" is no longer useful now that
SVN is deprecated in Chromium. Additionally, the "use_mirror" logic
should have been determined in the "gclient" recipe module, not in the
core recipe engine.

BUG=None
TEST=None
==========

to

==========
Remove 'use_mirror' and 'root' properties.

Remove the recipe engine special case "use_mirror" and "root" property
logic. "root" is very old, and "use_mirror" is no longer useful now that
SVN is deprecated in Chromium. Additionally, the "use_mirror" logic
should have been determined in the "gclient" recipe module, not in the
core recipe engine.

BUG=chromium:656731
TEST=None
==========

[dnj, 2016-10-17 18:54:34]

Ughhhhhhhhhhh addressed via: https://codereview.chromium.org/2427763002/

[dnj, 2016-10-17 19:12:38]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:12:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 19:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:17:53]

Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31ece11ea021e710)

[iannucci, 2016-10-17 21:11:35]

lgtm

[dnj, 2016-10-17 21:13:02]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-10-17 21:13:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 21:16:00]

Description was changed from

==========
Remove 'use_mirror' and 'root' properties.

Remove the recipe engine special case "use_mirror" and "root" property
logic. "root" is very old, and "use_mirror" is no longer useful now that
SVN is deprecated in Chromium. Additionally, the "use_mirror" logic
should have been determined in the "gclient" recipe module, not in the
core recipe engine.

BUG=chromium:656731
TEST=None
==========

to

==========
Remove 'use_mirror' and 'root' properties.

Remove the recipe engine special case "use_mirror" and "root" property
logic. "root" is very old, and "use_mirror" is no longer useful now that
SVN is deprecated in Chromium. Additionally, the "use_mirror" logic
should have been determined in the "gclient" recipe module, not in the
core recipe engine.

BUG=chromium:656731
TEST=None

Committed:
https://github.com/luci/recipes-py/commit/bb6caf8060139fd4bcefee43f54ae00150e...
==========

[commit-bot: I haz the power, 2016-10-17 21:16:01]

Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/bb6caf8060139fd4bcefee43f54ae00150e...