Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html

Issue 2421093003: Allow redirects for requests that require preflight. (Closed)
Patch Set: Fix failing test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html
index 83fc3b650b9786d4ccaff354a084a4c6e90f5f7b..738f44bf5781ae2d6e8f23039f8f257313164199 100644
--- a/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html
+++ b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html
@@ -49,10 +49,8 @@ var tests = [
// Receives a redirect response with CORS headers. The redirect response passes the access check and the resource response
// passes the access check.
-// FIXME: this test fails because the redirect is vetoed. There are continued bugs with redirects when the original
-// request was cross-origin.
["http://localhost:8000/xmlhttprequest/resources/redirect-cors.php?url=http://localhost:8000/xmlhttprequest/resources/access-control-basic-allow-star.cgi&\
- access-control-allow-origin=http://localhost:8000",
+ access-control-allow-origin=http://127.0.0.1:8000",
yhirano 2016/11/16 08:20:28 Hm, the document origin is http://127.0.0.1:8000 a
Jack Bates 2016/11/20 18:51:11 Done.
withoutCredentials, noCustomHeader, succeeds],
// Receives a redirect response with a URL containing the userinfo production.
@@ -78,7 +76,7 @@ var tests = [
url=http://localhost:8000/xmlhttprequest/resources/access-control-basic-allow-star.cgi&\
access-control-allow-origin=*&\
access-control-allow-headers=x-webkit",
- withoutCredentials, addCustomHeader, fails],
+ withoutCredentials, addCustomHeader, succeeds],
// 3) Test same origin requests with a custom header that receive a same origin redirect.
["resources/redirect-cors.php?url=http://127.0.0.1:8000/xmlhttprequest/resources/get.txt",

Powered by Google App Engine
This is Rietveld 408576698