Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2421083002: Replace FOR_EACH_OBSERVER in components/drive with range-based for (Closed)

Created:
4 years, 2 months ago by Yusuke Sato
Modified:
4 years, 2 months ago
Reviewers:
kinaba
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace FOR_EACH_OBSERVER in components/drive with range-based for BUG=655021 TEST=try, git grep FOR_EACH_OBSERVER components/drive Committed: https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec Cr-Commit-Position: refs/heads/master@{#425717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -37 lines) Patch
M components/drive/chromeos/change_list_loader.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M components/drive/chromeos/directory_loader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/drive/chromeos/file_system.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M components/drive/drive_app_registry.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/drive/drive_notification_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/drive/job_scheduler.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/drive/service/drive_api_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/drive/service/fake_drive_service.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Yusuke Sato
PTAL This was done with cd components/drive/ && perl -0777 -pi -e 's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for (auto& observer ...
4 years, 2 months ago (2016-10-17 05:11:47 UTC) #6
kinaba
lgtm. Thanks!
4 years, 2 months ago (2016-10-17 05:13:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421083002/1
4 years, 2 months ago (2016-10-17 16:54:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 17:42:53 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 17:44:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c089bc9d43787ec77a2cc8eedc0ff6a0f8470ec
Cr-Commit-Position: refs/heads/master@{#425717}

Powered by Google App Engine
This is Rietveld 408576698