Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 242107: Add histograms that track how long it takes to open the new tab page. (Closed)

Created:
11 years, 2 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add histograms that track how long it takes to open the new tab page. This doesn't time all loads of the new tab page, just new foreground tabs using ctrl+t or the plus button. This includes the time it takes to create the tab contents and logs the time until JS has started executing, domcontentloaded, and onload. Note: onload doesn't mean the page is done loading. We have "NewTabUI load" for that. BUG=23120 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27918

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix accidental removal of new lines #

Patch Set 3 : meh #

Total comments: 1

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -8 lines) Patch
M chrome/browser/browser.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 2 3 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
11 years, 2 months ago (2009-10-01 22:39:28 UTC) #1
tony
Oh, I should add that if someone uses ctrl+t, this doesn't include the time it ...
11 years, 2 months ago (2009-10-01 22:42:41 UTC) #2
jam
lgtm http://codereview.chromium.org/242107/diff/1/3 File chrome/browser/dom_ui/new_tab_ui.cc (right): http://codereview.chromium.org/242107/diff/1/3#newcode779 Line 779: }void MostVisitedHandler::AddPinnedURL(const MostVisitedPage& page, int index) { ...
11 years, 2 months ago (2009-10-02 00:47:49 UTC) #3
arv (Not doing code reviews)
LGTM http://codereview.chromium.org/242107/diff/6001/6006 File chrome/browser/tab_contents/tab_contents.cc (right): http://codereview.chromium.org/242107/diff/6001/6006#newcode1181 Line 1181: UMA_HISTOGRAM_TIMES("NewTab.ScriptStart", duration); Why don't we send these ...
11 years, 2 months ago (2009-10-02 01:24:52 UTC) #4
tony
11 years, 2 months ago (2009-10-02 23:28:04 UTC) #5
Ok, updated to use the NewTab.* in the js code as well.

Powered by Google App Engine
This is Rietveld 408576698