Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2421063002: NQE: Separate out params to a different file (Closed)
Patch Set: ps Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 7c3525ead88e7f6d09b5c4eb462ed9bf00f14f0b..7bf745c3c913ab18a0b8ddefcdbde945c2d8a9de 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -420,14 +420,6 @@ class NET_EXPORT NetworkQualityEstimator
kDefaultEffectiveConnectionTypeAlgorithm =
EffectiveConnectionTypeAlgorithm::HTTP_RTT_AND_DOWNSTREAM_THROUGHOUT;
- // Minimum valid value of the variation parameter that holds RTT (in
- // milliseconds) values.
- static const int kMinimumRTTVariationParameterMsec = 1;
-
- // Minimum valid value of the variation parameter that holds throughput (in
- // kilobits per second) values.
- static const int kMinimumThroughputVariationParameterKbps = 1;
-
// Returns the RTT value to be used when the valid RTT is unavailable. Readers
// should discard RTT if it is set to the value returned by |InvalidRTT()|.
static const base::TimeDelta InvalidRTT();
@@ -455,15 +447,11 @@ class NET_EXPORT NetworkQualityEstimator
void OnUpdatedRTTAvailable(SocketPerformanceWatcherFactory::Protocol protocol,
const base::TimeDelta& rtt);
- // Obtains operating parameters from the field trial parameters.
- void ObtainOperatingParams(
- const std::map<std::string, std::string>& variation_params);
-
// Obtains the model parameters for different effective connection types from
// the field trial parameters. For each effective connection type, a model
// (currently composed of a RTT threshold and a downlink throughput threshold)
// is provided by the field trial.
- void ObtainEffectiveConnectionTypeModelParams(
+ void ObtainOperatingParams(
const std::map<std::string, std::string>& variation_params);
// Adds the default median RTT and downstream throughput estimate for the
@@ -624,12 +612,6 @@ class NET_EXPORT NetworkQualityEstimator
nqe::internal::NetworkQuality
default_observations_[NetworkChangeNotifier::CONNECTION_LAST + 1];
- // Default thresholds for different effective connection types. The default
- // values are used if the thresholds are unavailable from the variation
- // params.
- nqe::internal::NetworkQuality default_effective_connection_type_thresholds_
- [EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_LAST];
-
// Thresholds for different effective connection types obtained from field
// trial variation params. These thresholds encode how different connection
// types behave in general. In future, complex encodings (e.g., curve
@@ -716,7 +698,7 @@ class NET_EXPORT NetworkQualityEstimator
// parameters. If set to true, GetEffectiveConnectionType() will always return
// |forced_effective_connection_type_|.
const bool forced_effective_connection_type_set_;
- EffectiveConnectionType forced_effective_connection_type_;
+ const EffectiveConnectionType forced_effective_connection_type_;
base::ThreadChecker thread_checker_;

Powered by Google App Engine
This is Rietveld 408576698