Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2421033003: Revert of mjsunit: Fix the error message produced by assertInstanceof. (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of mjsunit: Fix the error message produced by assertInstanceof. (patchset #1 id:1 of https://codereview.chromium.org/2413153004/ ) Reason for revert: This is probably not working for falsey values. I cannot JavaScript :P Original issue's description: > mjsunit: Fix the error message produced by assertInstanceof. > > Used to be: > > Failure: expected <foo> is not an instance of <Bar> but of < Baz>> found <undefined> > > Should be: > > Failure: <foo> is not an instance of <Bar> but of <Baz> > > BUG= > > Committed: https://crrev.com/2a480eff395756f36eb0ae2fc0a573454b394268 > Cr-Commit-Position: refs/heads/master@{#40319} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7d1a7df12091ef8476b5049e767ef2bd481c80c0 Cr-Commit-Position: refs/heads/master@{#40331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M test/mjsunit/mjsunit.js View 2 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
marja
Created Revert of mjsunit: Fix the error message produced by assertInstanceof.
4 years, 2 months ago (2016-10-15 06:33:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421033003/1
4 years, 2 months ago (2016-10-15 06:33:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-15 06:33:54 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-15 06:34:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d1a7df12091ef8476b5049e767ef2bd481c80c0
Cr-Commit-Position: refs/heads/master@{#40331}

Powered by Google App Engine
This is Rietveld 408576698