Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 242103013: Add --runOnce flag to run benchs once in release or to force convergence in debug (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add --runOnce flag to run benchs once in release or to force convergence in debug Committed: http://code.google.com/p/skia/source/detail?r=14292

Patch Set 1 #

Patch Set 2 : remove double space from error print #

Total comments: 2

Patch Set 3 : show timings in debug with "--runOnce false" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M bench/benchmain.cpp View 1 2 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
6 years, 8 months ago (2014-04-21 19:48:33 UTC) #1
mtklein
https://codereview.chromium.org/242103013/diff/20001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/242103013/diff/20001/bench/benchmain.cpp#newcode678 bench/benchmain.cpp:678: if (kIsDebug || FLAGS_runOnce) { Let's just fold it ...
6 years, 8 months ago (2014-04-21 20:04:15 UTC) #2
bsalomon
https://codereview.chromium.org/242103013/diff/20001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/242103013/diff/20001/bench/benchmain.cpp#newcode678 bench/benchmain.cpp:678: if (kIsDebug || FLAGS_runOnce) { On 2014/04/21 20:04:16, mtklein ...
6 years, 8 months ago (2014-04-21 20:42:50 UTC) #3
mtklein
On 2014/04/21 20:42:50, bsalomon wrote: > https://codereview.chromium.org/242103013/diff/20001/bench/benchmain.cpp > File bench/benchmain.cpp (right): > > https://codereview.chromium.org/242103013/diff/20001/bench/benchmain.cpp#newcode678 > ...
6 years, 8 months ago (2014-04-21 20:48:49 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-21 20:49:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/242103013/40001
6 years, 8 months ago (2014-04-21 20:49:59 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 21:12:34 UTC) #7
Message was sent while issue was closed.
Change committed as 14292

Powered by Google App Engine
This is Rietveld 408576698