Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2421013002: Implement M SDK Android accessibility actions (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
paulmiller
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement M SDK Android accessibility actions ACTION_CONTEXT_CLICK ACTION_SHOW_ON_SCREEN ACTION_SCROLL_UP ACTION_SCROLL_DOWN ACTION_SCROLL_LEFT ACTION_SCROLL_RIGHT These were all pretty straightforward as we already supported them internally. BUG=656104, 483653 Committed: https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d Cr-Commit-Position: refs/heads/master@{#425769}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 5 chunks +42 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dmazzoni
4 years, 2 months ago (2016-10-14 20:34:46 UTC) #2
paulmiller
LGTM
4 years, 2 months ago (2016-10-14 21:46:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421013002/20001
4 years, 2 months ago (2016-10-17 18:56:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 20:42:05 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 20:43:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a08ff35da49a509eb05c3a8ed165565c7ca978d
Cr-Commit-Position: refs/heads/master@{#425769}

Powered by Google App Engine
This is Rietveld 408576698