Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 24210011: Handlify JSObject::MigrateInstance and friends. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger
Modified:
7 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Handlify JSObject::MigrateInstance and friends. This relands the original change from r16899 together with a bugfix for two unhandlified values which became stale. R=verwaest@chromium.org TEST=mjsunit/debug-evaluate-locals-optimized (in GC stress mode) Committed: http://code.google.com/p/v8/source/detail?r=16905

Patch Set 1 #

Patch Set 2 : Fix stale raw pointers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -60 lines) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 3 chunks +6 lines, -4 lines 0 comments Download
M src/objects.cc View 1 4 chunks +34 lines, -38 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
Review instructions: - Patch set #1: Dupe of https://codereview.chromium.org/23583052/ - Patch set #2: The actual ...
7 years, 2 months ago (2013-09-23 18:04:26 UTC) #1
Toon Verwaest
doh! lgtm.
7 years, 2 months ago (2013-09-23 19:24:18 UTC) #2
Michael Starzinger
7 years, 2 months ago (2013-09-23 19:56:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16905 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698