Issue 24210010: Add layout test to verify that compositing is sticky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24210010: Add layout test to verify that compositing is sticky. (Closed)

Created:
7 years, 3 months ago by ccameron

Modified:
7 years, 2 months ago

Reviewers:
jamesr

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add layout test to verify that compositing is sticky. Add a div that will trigger compositing, and then remove it. Dump the layer tree at each step and verify that it is full. BUG=295072

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	A	LayoutTests/compositing/sticky-compositing.html	View		1 chunk	+36 lines, -0 lines	0 comments	Download
	A	LayoutTests/compositing/sticky-compositing-expected.txt	View		1 chunk	+11 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ccameron

https://codereview.chromium.org/24210010/diff/1/LayoutTests/compositing/sticky-compositing-expected.txt File LayoutTests/compositing/sticky-compositing-expected.txt (right): https://codereview.chromium.org/24210010/diff/1/LayoutTests/compositing/sticky-compositing-expected.txt#newcode8 LayoutTests/compositing/sticky-compositing-expected.txt:8: This is empty on TOT ... this will be ...

7 years, 3 months ago (2013-09-19 23:00:38 UTC) #1

jamesr

7 years, 3 months ago (2013-09-19 23:02:42 UTC) #2

Sorry, I meant a chromium patch covering the content:: logic.  We shouldn't have
layout tests for logic that lives 100% in src/content/renderer/.  Take a look at
content/renderer/render_*test.cc for inspiration.

Expand Messages | Collapse Messages