runtime/vm/debugger_api_impl_test.cc - Issue 24210003: Never return a Dart_Handle on a dart::Class from the embedding API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 24210003: Never return a Dart_Handle on a dart::Class from the embedding API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: remove Dart_IsClass from header. remove demo assert Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger_api_impl_test.cc

diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc

index 2426b3fd64f7c11da63886856b10a5cfa017ec0a..d73e812806265e542cd748fffc451584ad37a1d6 100644

--- a/runtime/vm/debugger_api_impl_test.cc

+++ b/runtime/vm/debugger_api_impl_test.cc

@@ -963,7 +963,7 @@ TEST_CASE(Debug_InspectObject) {

EXPECT_STREQ("blah blah", value);

// Check static field of B's superclass.

- Dart_Handle class_A = Dart_GetSuperclass(class_B);

+ Dart_Handle class_A = Dart_GetSupertype(class_B);

EXPECT_VALID(class_A);

EXPECT(!Dart_IsNull(class_A));

fields = Dart_GetStaticFields(class_A);

« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | runtime/vm/mirrors_api_impl.cc » ('j') | no next file with comments »