Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

Issue 2420983002: AudioParams with automations must process timelines (Closed)
Patch Set: Use kRenderQuantumFrames. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
index 216364574716eb7ff54797cfe985499ae703244f..10c71859d4f2fe05080a968e641e0a0d593ff710 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
@@ -330,6 +330,10 @@ void AudioHandler::processIfNecessary(size_t framesToProcess) {
if (silentInputs && propagatesSilence()) {
silenceOutputs();
+ // AudioParams still need to be processed so that the value can be updated
+ // if there are automations or so that the upstream nodes get pulled if
+ // any are connected to the AudioParam.
+ processAudioParams(framesToProcess);
} else {
// Unsilence the outputs first because the processing of the node may
// cause the outputs to go silent and we want to propagate that hint to

Powered by Google App Engine
This is Rietveld 408576698