chrome/browser/resources/task_scheduler_internals/index.css - Issue 2420973002: Plumb Task Scheduler Histograms to the Task Scheduler Internals Page

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/task_scheduler_internals/index.css

Issue 2420973002: Plumb Task Scheduler Histograms to the Task Scheduler Internals Page (Closed)

Patch Set: CR Feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 /* Copyright 2016 The Chromium Authors. All rights reserved.	1 /* Copyright 2016 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file. */	3 * found in the LICENSE file. */

4	4

5 #clear-drive-cache-overlay-page {	5 table {

6 max-width: 476px;	6 border: 1px solid black;

	7 border-collapse: collapse;

7 }	8 }

8	9

9 #clear-drive-cache-overlay-page p {	10 td,

10 line-height: 1.6em;	11 th {

	12 border: 1px solid black;

	13 padding: 5px;

	14 text-align: center;

11 }	15 }

	16

	17 #details {
	xiyuan 2016/10/19 17:49:57 nit: get rid of this and use hidden in html: <d nit: get rid of this and use hidden in html: <div id="details" hidden> in js: $('details').hidden = !data.instantiated robliao 2016/10/19 21:24:28 Done. Show quoted text On 2016/10/19 17:49:57, xiyuan wrote: > nit: get rid of this and use hidden > > in html: > <div id="details" hidden> > > in js: > $('details').hidden = !data.instantiated Done.
	18 visibility: hidden;
	Dan Beam 2016/10/29 01:13:24 can we just use the [hidden] attribute in HTML ins can we just use the [hidden] attribute in HTML instead? robliao 2016/11/08 18:14:18 On Trunk: Hidden attribute used at commit. Show quoted text On 2016/10/29 01:13:24, Dan Beam wrote: > can we just use the [hidden] attribute in HTML instead? On Trunk: Hidden attribute used at commit.
	19 }

OLD	NEW